kennknowles commented on code in PR #33979:
URL: https://github.com/apache/beam/pull/33979#discussion_r1955144877
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ConvertHelpers.java:
##########
@@ -85,57 +100,58 @@ public ConvertedSchemaInformation(
public static <T> ConvertedSchemaInformation<T>
getConvertedSchemaInformation(
Schema inputSchema, TypeDescriptor<T> outputType, SchemaRegistry
schemaRegistry) {
- ConvertedSchemaInformation<T> schemaInformation = null;
+ ConvertedSchemaInformation<T> schemaInformation;
// Try to load schema information from loaded providers
- for (SchemaInformationProvider provider :
SchemaInformationProviders.INSTANCE) {
- schemaInformation = provider.getConvertedSchemaInformation(inputSchema,
outputType);
- if (schemaInformation != null) {
- return schemaInformation;
+ try {
+ for (SchemaInformationProvider provider :
getSchemaInformationProviders()) {
+ schemaInformation =
provider.getConvertedSchemaInformation(inputSchema, outputType);
+ if (schemaInformation != null) {
+ return schemaInformation;
+ }
}
+ } catch (Exception e) {
+ LOG.debug("No Schema information found for type {}", outputType, e);
Review Comment:
This message doesn't seem fully accurate, since we are not yet done checking
for schemas, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
