kennknowles commented on code in PR #33979:
URL: https://github.com/apache/beam/pull/33979#discussion_r1956079482
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ConvertHelpers.java:
##########
@@ -85,57 +100,58 @@ public ConvertedSchemaInformation(
public static <T> ConvertedSchemaInformation<T>
getConvertedSchemaInformation(
Schema inputSchema, TypeDescriptor<T> outputType, SchemaRegistry
schemaRegistry) {
- ConvertedSchemaInformation<T> schemaInformation = null;
+ ConvertedSchemaInformation<T> schemaInformation;
Review Comment:
In practice, new classes would have to be loaded / added to classpath. I
think the way we use service loaders is fixed when things are launched, unless
someone is getting quite fancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
