je-ik commented on a change in pull request #12759:
URL: https://github.com/apache/beam/pull/12759#discussion_r482779726
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -1330,6 +1338,19 @@ public void setTimer(
@Deprecated
@Override
public void setTimer(TimerData timer) {
+ if (timer.getTimestamp().isAfter(GlobalWindow.INSTANCE.maxTimestamp())) {
Review comment:
We could create a NonGlobalWindowCleanupTimer (or something similar) in
runner-core and reuse it in both portability and non-portable runner. If the
code duplication would be the biggest concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
