mxm commented on a change in pull request #12759:
URL: https://github.com/apache/beam/pull/12759#discussion_r484498315
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -753,6 +754,13 @@ private void maybeEmitWatermark(long watermark) {
LOG.debug("Emitting watermark {}", watermark);
currentOutputWatermark = watermark;
output.emitWatermark(new Watermark(watermark));
+
+ // Check if the final watermark was triggered to perform state cleanup
for global window
+ if (keyedStateInternals != null
+ && currentOutputWatermark
Review comment:
Due to all logic now being in keyedStateInternals, we need the null
check. The state internals will be null if we do not have keyed input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
