shunping commented on PR #34103: URL: https://github.com/apache/beam/pull/34103#issuecomment-2690894227
> Good call, we had some tests that would tangentially fail if the change was made incorrectly but didn't have direct unit test cases that would fail. Added two quick unit test cases that apply here, I'll make a note to go back and add tests that route through `normalize()` for the primitives once I'm done cleaning up the internal code changes That's great. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
