Abacn commented on code in PR #34128:
URL: https://github.com/apache/beam/pull/34128#discussion_r1978085432
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -84,7 +84,7 @@ public Schema configurationSchema() {
*/
@Override
public JdbcSchemaIO from(String location, Row configuration, @Nullable
Schema dataSchema) {
- return new JdbcSchemaIO(location, configuration);
+ return new JdbcSchemaIO(location, configuration, dataSchema);
Review Comment:
I see, previously the dataSchema parameter wasn't passed down stream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
