claudevdm commented on code in PR #34128:
URL: https://github.com/apache/beam/pull/34128#discussion_r1978110130
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java:
##########
@@ -84,7 +84,7 @@ public Schema configurationSchema() {
*/
@Override
public JdbcSchemaIO from(String location, Row configuration, @Nullable
Schema dataSchema) {
- return new JdbcSchemaIO(location, configuration);
+ return new JdbcSchemaIO(location, configuration, dataSchema);
Review Comment:
Yeah and in the JdbcIO#readRows and readWithPartitions there schema case
wasnt handled.
I also need to add the ability to explicitly pass the partition lower and
upper bounds through xlang, otherwise that part will also happen at pipeline
construction time. Will do in a followup later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
