Strikerrx01 commented on PR #34135: URL: https://github.com/apache/beam/pull/34135#issuecomment-2697152811
R: @stankiewicz Thanks for the review. I've addressed your feedback: 1. Removed redundant `field_type.upper()` call since the type is already uppercase 2. Fixed temp dataset handling logic to preserve original behavior with `temp_dataset_id or (BigQueryWrapper.TEMP_DATASET + self._temporary_table_suffix)` 3. Added comprehensive test coverage for caching functionality in `bigquery_tools_test.py` Could you please review the updated code in `bigquery_tools.py` and `bigquery_tools_test.py`? The new tests verify caching behavior, TTL validation, and thread safety. Please let me know if you'd like me to explain anything further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
