Strikerrx01 commented on code in PR #34135:
URL: https://github.com/apache/beam/pull/34135#discussion_r1979284714
##########
sdks/python/apache_beam/io/gcp/bigquery_tools.py:
##########
@@ -384,10 +388,28 @@ def __init__(self, client=None, temp_dataset_id=None,
temp_table_ref=None):
else:
self.temp_table_ref = None
self._temporary_table_suffix = uuid.uuid4().hex
- self.temp_dataset_id = temp_dataset_id or self._get_temp_dataset()
Review Comment:
@stankiewicz You're absolutely right about the `_get_temp_dataset` method. I
apologize for inlining the logic. We should use the existing method:
Current code: self.temp_dataset_id = temp_dataset_id or
self.get_temp_dataset()
Should be changed to: self.temp_dataset_id = temp_dataset_id or
self.get_temp_dataset()
I'll update the code to use `_get_temp_dataset()`. Would you like me to make
this change along with the method reordering in a single commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
