claudevdm commented on code in PR #34324:
URL: https://github.com/apache/beam/pull/34324#discussion_r1999328204
##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads.py:
##########
@@ -664,19 +664,14 @@ def start_bundle(self):
self.pending_jobs = []
self.schema_cache = {}
- def process(
- self,
- element,
- load_job_name_prefix,
- pane_info=beam.DoFn.PaneInfoParam,
Review Comment:
We are still using pane info, but just adding it earlier as part of the key
that gets processed by TriggerLoadJob,=
##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads.py:
##########
@@ -664,19 +664,14 @@ def start_bundle(self):
self.pending_jobs = []
self.schema_cache = {}
- def process(
- self,
- element,
- load_job_name_prefix,
- pane_info=beam.DoFn.PaneInfoParam,
Review Comment:
We are still using pane info, but just adding it earlier as part of the key
that gets processed by TriggerLoadJob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
