Abacn commented on code in PR #34324:
URL: https://github.com/apache/beam/pull/34324#discussion_r1999965473
##########
sdks/python/apache_beam/io/gcp/bigquery_file_loads.py:
##########
@@ -1313,3 +1312,9 @@ def expand(self, pcoll):
self.DESTINATION_FILE_PAIRS: all_destination_file_pairs_pc,
self.DESTINATION_COPY_JOBID_PAIRS: destination_copy_job_ids_pc,
}
+
+
+class KeyByPaneIndex(beam.DoFn):
+ def process(self, element, pane_info=beam.DoFn.PaneInfoParam):
+ destination, (partition_key, files) = element
+ return [(destination, (partition_key, files, pane_info.index))]
Review Comment:
This is very similar to a first attempt to fix the same issue in Java -
#28272 add pane info in "WritePartition" so it is survived in ReShuffle. In
earlier discussion it was decided to go with fixing ReShuffle itself (and that
PR was closed). Shall we go for same decision here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
