claudevdm commented on code in PR #34348: URL: https://github.com/apache/beam/pull/34348#discussion_r2014576179
########## sdks/python/apache_beam/transforms/util.py: ########## @@ -949,6 +952,97 @@ def is_compat_version_prior_to(options, breaking_change_version): return False +def _default_window_reify_functions(should_keep_paneinfo): + globally_windowed = window.GlobalWindows.windowed_value(None) + MIN_TIMESTAMP = window.MIN_TIMESTAMP + + if should_keep_paneinfo: + + def reify_metadata( Review Comment: This is probably my lack of understanding about what breaks update compatibility, but I was thinking for the non compatible case we need to maintain the original function names (reify_timestamps and restore_timestamps). Are you suggesting to define functions at the top level with different names e.g. for default windowing _default_reify_timestamps _default_restore_timestamps for non default windowing _custom_reify_timestamps _custom_restore_timestamps And then the same repeated for the pane info case Does update compatibility not break when these function names change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
