claudevdm commented on code in PR #34348: URL: https://github.com/apache/beam/pull/34348#discussion_r2015084523
########## sdks/go/pkg/beam/runners/prism/internal/urns/urns.go: ########## @@ -124,6 +124,7 @@ var ( CoderTimer = cdrUrn(pipepb.StandardCoders_TIMER) CoderKV = cdrUrn(pipepb.StandardCoders_KV) + CoderTuple = "beam:coder:tuple:v1" Review Comment: It seems unkown coders are only legth prefixed if they are "leaf" and no sub-components coders. The tuple coder has sub components, so it is not length prefixed https://github.com/apache/beam/blob/23f27df20a6cbdcb62c87157449bf8004bcda017/sdks/go/pkg/beam/runners/prism/internal/coders.go#L126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org