yyfhust commented on code in PR #34505:
URL: https://github.com/apache/beam/pull/34505#discussion_r2024741168
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##########
@@ -1784,8 +1784,10 @@ public PCollection<KafkaRecord<K, V>> expand(PBegin
input) {
.withConsumerConfigOverrides(kafkaRead.getConsumerConfig())
.withOffsetConsumerConfigOverrides(kafkaRead.getOffsetConsumerConfig())
.withConsumerFactoryFn(kafkaRead.getConsumerFactoryFn())
-
.withKeyDeserializerProvider(kafkaRead.getKeyDeserializerProvider())
-
.withValueDeserializerProvider(kafkaRead.getValueDeserializerProvider())
+ .withKeyDeserializerProviderAndCoder(
+ kafkaRead.getKeyDeserializerProvider(), keyCoder)
+ .withValueDeserializerProviderAndCoder(
+ kafkaRead.getValueDeserializerProvider(), valueCoder)
Review Comment:
keyCoder and valueCoder must be non-nullable. they are resolved here
https://github.com/apache/beam/blob/800d434e862c3ea48c74a38a6ab96387ed06fbf1/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java#L1562-L1563
either from user input or infer from coderegistry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
