yyfhust commented on PR #34505: URL: https://github.com/apache/beam/pull/34505#issuecomment-2776179834
> I think they are still there just grouped together differently. > […](#) > On Thu, Apr 3, 2025, 4:23 PM johnjcasey ***@***.***> wrote: This change is technically not backwards compatible, because it removes the old, but public facing, methods on ReadSourceDescriptors. Can you keep those methods? — Reply to this email directly, view it on GitHub <[#34505 (comment)](https://github.com/apache/beam/pull/34505#issuecomment-2775964623)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBZZTHDTLTLNN4CEW6GX7D2XU75PAVCNFSM6AAAAAB2IH2E76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZVHE3DINRSGM> . You are receiving this because your review was requested.Message ID: ***@***.***> [image: johnjcasey]*johnjcasey* left a comment ([apache/beam#34505](https://github.com/apache/beam/pull/34505)) <[#34505 (comment)](https://github.com/apache/beam/pull/34505#issuecomment-2775964623)> This change is technically not backwards compatible, because it removes the old, but public facing, methods on ReadSourceDescriptors. Can you keep those methods? — Repl y to this email directly, view it on GitHub <[#34505 (comment)](https://github.com/apache/beam/pull/34505#issuecomment-2775964623)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBZZTHDTLTLNN4CEW6GX7D2XU75PAVCNFSM6AAAAAB2IH2E76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZVHE3DINRSGM> . You are receiving this because your review was requested.Message ID: ***@***.***> sorry i do not get what do you mean here ; would you mind giving more details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
