13MaxG commented on code in PR #34484:
URL: https://github.com/apache/beam/pull/34484#discussion_r2025196301
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py:
##########
@@ -388,7 +388,8 @@ def create_stages(
translations.lift_combiners,
translations.expand_sdf,
translations.expand_gbk,
- translations.sink_flattens,
+ translations.fix_flatten_coders,
Review Comment:
The `fix_flatten_coders` was added to solve yaml unit tests.
It also mimics the `translations.standard_optimize_phases()` used by
Portable Runner
Without it, the`YamlMappingTest::test_basic` yields
```
apache_beam.testing.util.BeamAssertException: Failed assert: [
Row(label='11a', isogeny='a'), Row(label='37a', isogeny='a'),
Row(label='389a', isogeny='a')] ==
[BeamSchema_ccf257cb_1966_410e_8157_00cd826e7392(label='11a', isogeny='a'),
BeamSchema_ccf257cb_1966_410e_8157_00cd826e7392(label='37a', isogeny='a'),
BeamSchema_ccf257cb_1966_410e_8157_00cd826e7392(label='389a', isogeny='a')],
unexpected elements
[BeamSchema_ccf257cb_1966_410e_8157_00cd826e7392(label='11a', isogeny='a'),
BeamSchema_ccf257cb_1966_410e_8157_00cd826e7392(label='37a', isogeny='a'),
BeamSchema_ccf257cb_1966_410e_8157_00cd826e7392(label='389a', isogeny='a')],
missing elements [Row(label='11a', isogeny='a'), Row(label='37a',
isogeny='a'), Row(label='389a', isogeny='a')
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
