claudevdm commented on code in PR #34484:
URL: https://github.com/apache/beam/pull/34484#discussion_r2025261569
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py:
##########
@@ -388,7 +388,8 @@ def create_stages(
translations.lift_combiners,
translations.expand_sdf,
translations.expand_gbk,
- translations.sink_flattens,
+ translations.fix_flatten_coders,
+ # translations.sink_flattens,
Review Comment:
To be clear, this PR isn't fixing the underlying issue, rather it is
disabling the optimization?
Can we add a comment referencing why this is disabled, with reference to the
bug?
Also I am not sure if the tradeoff between disabling this optimization is
worth fixing this specific edge-case, maybe @damccorm has thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
