m-trieu commented on code in PR #34367: URL: https://github.com/apache/beam/pull/34367#discussion_r2025714170
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/WindmillStreamSender.java: ########## @@ -165,4 +201,39 @@ long getAndResetThrottleTime() { long getCurrentActiveCommitBytes() { return workCommitter.currentActiveCommitBytes(); } + + /** + * Creates, starts, and gracefully terminates {@link GetWorkStream} before the clientside deadline + * to prevent {@link org.apache.beam.vendor.grpc.v1p69p0.io.grpc.Status#DEADLINE_EXCEEDED} errors. + * If at any point the server closes the stream, reconnects immediately. + */ + private void getWorkStreamLoop(CountDownLatch waitForInitialStream) { + @Nullable GetWorkStream newStream = null; + while (isRunning.get()) { + synchronized (activeGetWorkStream) { + newStream = getWorkStreamFactory.get(); Review Comment: allows the new `GetWorkBudget` to be propogated without coordinating any further sends wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org