acrites commented on code in PR #34367:
URL: https://github.com/apache/beam/pull/34367#discussion_r2045684742
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/AbstractWindmillStream.java:
##########
@@ -195,6 +228,12 @@ private void startStream() {
onNewStream();
if (clientClosed) {
halfClose();
+ } else {
+ // If the stream is alive, schedule a future restart. We also
attempt to cancel any
+ // pending restarts that have not run since they are used for
preventing
+ // DEADLINE_EXCEEDED. Everytime the stream restarts, this
deadline restarts so we want
+ // the stream restart to run whenever we restart the stream +
streamTTL.
+ scheduleRestart();
Review Comment:
Would this be an appropriate place to call
`requestObserver.startAsyncStreamCloser()`? It feels like this is the point
where we know the stream got created so we want to close it eventually (as
opposed to other code paths here in `startStream` where we might give up before
actually creating the stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
