shunping commented on issue #34564: URL: https://github.com/apache/beam/issues/34564#issuecomment-2784069140
In the examples, there is an "empty" transform with zero subtransforms (not meeting the requirement of https://github.com/apache/beam/blob/56e11aa1dabf5031e987d34fe804fd53bf11c429/sdks/go/pkg/beam/runners/prism/internal/jobservices/management.go#L242), but non-empty payload (not meeting the requirement of https://github.com/apache/beam/blob/56e11aa1dabf5031e987d34fe804fd53bf11c429/sdks/go/pkg/beam/runners/prism/internal/jobservices/management.go#L248). Therefore, it falls through to the check on https://github.com/apache/beam/blob/56e11aa1dabf5031e987d34fe804fd53bf11c429/sdks/go/pkg/beam/runners/prism/internal/jobservices/management.go#L253. Only fixing the checking in jobservices/management is not enough, as then the `empty` transform and the transform prior to it will have the same output pcollection, which will lead to another error raised about "two producers on the same pcollection" ( https://github.com/apache/beam/blob/56e11aa1dabf5031e987d34fe804fd53bf11c429/sdks/go/pkg/beam/runners/prism/internal/preprocess.go#L354) To fix the second issue, we will have to skip the "empty" transform during graph preparation (prior to sorting the topology), since it is an no-op that causes prism confused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
