lostluck commented on PR #34529: URL: https://github.com/apache/beam/pull/34529#issuecomment-2807336880
The Go changes LGTM, though I must remind that WRT the model, hints are only intended for performance, not correctness. That is, Ressource hints that a runner doesn't know, *must* be able to be ignored for correctness. For this one, I'd be most worried about trying to force single threading for such a bundle communicating to a GPU. On the other hand "Please run as many of these as the worker can handle eg. 100" would be very safe. Really depends on the intent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
