AMOOOMA commented on code in PR #34529:
URL: https://github.com/apache/beam/pull/34529#discussion_r2049908045
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/resourcehints/ResourceHints.java:
##########
@@ -339,10 +362,15 @@ public ResourceHints mergeWithOuter(ResourceHints outer) {
} else {
ImmutableMap.Builder<String, ResourceHint> newHints =
ImmutableMap.builder();
for (Map.Entry<String, ResourceHint> outerHint :
outer.hints().entrySet()) {
- if (hints.containsKey(outerHint.getKey())) {
+ String key = outerHint.getKey();
+ if (hints.containsKey(key)) {
newHints.put(
- outerHint.getKey(),
-
hints.get(outerHint.getKey()).mergeWithOuter(outerHint.getValue()));
+ key,
+ hints
+ .get(key)
+ .mergeWithOuter(
+ outerHint.getValue(),
+ /*isSum*/
outerHint.getKey().equals(MAX_ACTIVE_BUNDLES_PER_WORKER)));
Review Comment:
For sure. Some how missed this when updating things. Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
