Abacn commented on code in PR #34786:
URL: https://github.com/apache/beam/pull/34786#discussion_r2068971403


##########
sdks/python/apache_beam/io/gcp/gcsio_retry.py:
##########
@@ -54,9 +55,14 @@ def __call__(self, exc):
         _LOGGER.warning('cannot inspect the caller stack frame')
         return
 
-      # next_sleep is one of the arguments in the caller
+      # sleep_iterator is one of the arguments in the caller

Review Comment:
   I see, the cause of breakage is client change, and we relied on non-public 
implementation detail on throttlng.
   
   Does the change work with old client library?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to