akashorabek commented on code in PR #34786:
URL: https://github.com/apache/beam/pull/34786#discussion_r2071905212
##########
sdks/python/apache_beam/io/gcp/gcsio_retry.py:
##########
@@ -54,9 +55,14 @@ def __call__(self, exc):
_LOGGER.warning('cannot inspect the caller stack frame')
return
- # next_sleep is one of the arguments in the caller
+ # sleep_iterator is one of the arguments in the caller
Review Comment:
Added functionality for dynamic selection of the arg name depending on the
version of google-api-core
Successful run example with `google-api-core` >= 2.25.0rc0 -
https://github.com/akashorabek/beam/actions/runs/14795779558
Successful run example with `google-api-core` < 2.25.0rc0 -
https://github.com/akashorabek/beam/actions/runs/14796135246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
