Abacn commented on code in PR #34824: URL: https://github.com/apache/beam/pull/34824#discussion_r2073633443
########## sdks/python/apache_beam/coders/typecoders.py: ########## @@ -92,6 +93,7 @@ def register_standard_coders(self, fallback_coder): self._register_coder_internal(bytes, coders.BytesCoder) self._register_coder_internal(bool, coders.BooleanCoder) self._register_coder_internal(str, coders.StrUtf8Coder) + self._register_coder_internal(windowed_value.PaneInfo, coders.PaneInfoCoder) Review Comment: This fix has a large blast radius. It changed registered standard coders which is default behavior globally. Shall we do this or just put a coder implementation in new ReShuffle? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org