claudevdm commented on code in PR #34824:
URL: https://github.com/apache/beam/pull/34824#discussion_r2073654232
##########
sdks/python/apache_beam/coders/typecoders.py:
##########
@@ -92,6 +93,7 @@ def register_standard_coders(self, fallback_coder):
self._register_coder_internal(bytes, coders.BytesCoder)
self._register_coder_internal(bool, coders.BooleanCoder)
self._register_coder_internal(str, coders.StrUtf8Coder)
+ self._register_coder_internal(windowed_value.PaneInfo,
coders.PaneInfoCoder)
Review Comment:
Are you suggesting to define PaneInfoCoder here
https://github.com/apache/beam/blob/6f2f960b35957a7227286634d96108d6c4eb3003/sdks/python/apache_beam/transforms/util.py#L996
and then use `CoderRegistry.register_coder`?
I don't have strong opinion, is there a disadvantage to doing it here? It
seems like an 'internal' coder use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
