wollowizard commented on issue #34749: URL: https://github.com/apache/beam/issues/34749#issuecomment-2854237663
hi @scwhittle that was my first try but I seem to remember that it didn't work because the reader and writer are not serializable. I guess that is also the reason why an `EmptyOnDeserializationThreadLocal`was used, instead of a plain `ThreadLocal`. Would you like me to double check that? Also, yes I confirm there are places even in the beam sdk where the same AvroCoder is instantiated multiple times instead of being cached, for example [here](https://github.com/apache/beam/blob/5288c548e9e384dbf652e4297a6f0bfec5e94383/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedSource.java#L234) (those multiple allocations are visible in the memory allocation flame graph too) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
