wollowizard commented on issue #34749:
URL: https://github.com/apache/beam/issues/34749#issuecomment-2854500139

   If I understand well, you propose to have a static cache within `AvroCoder` 
to cache a full AvroCoder, right?
   
   I think this indeed solves the problem of people creating new AvroCoders 
outside of graph setup. And this not just in the sdk but also in user code 
(actually we had this exact issue in our own code base too, that's where my 
investigation starts from). 
   
   For example a developer writing a coder for kafka events can very easily end 
up creating a new AvroCoder at every received kafka message and the costs 
associated with it are unclear to a developer that hasn't run a profiler with a 
realistic workload.
   
   @scwhittle Would you like me to open a PR to do that? Also, would you 
consider merging this PR first so it has a chance of being included in the next 
beam release, and in parallel open another issue to work on your proposal?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to