wollowizard commented on code in PR #34873:
URL: https://github.com/apache/beam/pull/34873#discussion_r2077484721
##########
sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java:
##########
@@ -416,6 +417,40 @@ public void testReflectRecordEncoding() throws Exception {
CoderProperties.coderDecodeEncodeEqual(coderWithSchema,
AVRO_SPECIFIC_RECORD);
}
+ @Test
+ public void testCoderCached() {
+ Schema schema = AVRO_SPECIFIC_RECORD.getSchema();
+ TypeDescriptor<TestAvro> typeDescriptor =
TypeDescriptor.of(TestAvro.class);
+ Class<TestAvro> clazz = TestAvro.class;
+ boolean useReflectApi = false;
+ AvroDatumFactory<TestAvro> datumFactory = new
AvroDatumFactory.ReflectDatumFactory<>(clazz);
+
+ assertSame(AvroCoder.of(clazz), AvroCoder.of(clazz));
+ assertSame(AvroCoder.of(clazz, useReflectApi), AvroCoder.of(clazz,
useReflectApi));
+ assertSame(AvroCoder.of(typeDescriptor), AvroCoder.of(typeDescriptor));
+ assertSame(
+ AvroCoder.of(typeDescriptor, useReflectApi),
AvroCoder.of(typeDescriptor, useReflectApi));
+ assertSame(AvroCoder.of(clazz, schema), AvroCoder.of(clazz, schema));
+ assertSame(
+ AvroCoder.of(clazz, schema, useReflectApi), AvroCoder.of(clazz,
schema, useReflectApi));
+ assertSame(AvroCoder.of(datumFactory, schema), AvroCoder.of(datumFactory,
schema));
+
+ assertSame(AvroCoder.specific(clazz), AvroCoder.specific(clazz));
Review Comment:
done see last check in this test
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/coders/AvroGenericCoder.java:
##########
@@ -17,17 +17,27 @@
*/
package org.apache.beam.sdk.extensions.avro.coders;
+import java.util.concurrent.ExecutionException;
import org.apache.avro.Schema;
import org.apache.avro.generic.GenericRecord;
import org.apache.beam.sdk.extensions.avro.io.AvroDatumFactory;
+import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.cache.Cache;
+import
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.cache.CacheBuilder;
/** AvroCoder specialisation for GenericRecord, needed for cross-language
transforms. */
public class AvroGenericCoder extends AvroCoder<GenericRecord> {
+ private static final Cache<Schema, AvroGenericCoder>
AVRO_GENERIC_CODER_CACHE =
+ CacheBuilder.newBuilder().build();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
