scwhittle commented on code in PR #34873:
URL: https://github.com/apache/beam/pull/34873#discussion_r2081742961
##########
sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoderTest.java:
##########
@@ -416,6 +419,88 @@ public void testReflectRecordEncoding() throws Exception {
CoderProperties.coderDecodeEncodeEqual(coderWithSchema,
AVRO_SPECIFIC_RECORD);
}
+ @Test
+ public void testCoderCached() {
+ Schema schema = AVRO_SPECIFIC_RECORD.getSchema();
+ TypeDescriptor<TestAvro> typeDescriptor =
TypeDescriptor.of(TestAvro.class);
+ Class<TestAvro> clazz = TestAvro.class;
+ boolean useReflectApi = false;
Review Comment:
nit: how about
final boolean USE_REFLECT_API = true;
I was a little confused about this at first thinking you meant to test with
both true/false. But it's also odd to set this to false if the parameter is
useReflectApi as it is then inverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
