scwhittle commented on code in PR #34746:
URL: https://github.com/apache/beam/pull/34746#discussion_r2077415353


##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateFetchingIterators.java:
##########
@@ -91,6 +94,82 @@ public static <T> CachingStateIterable<T> 
readAllAndDecodeStartingFrom(
         valueCoder);
   }
 
+  public static <T> UncachedStateIterable<T> readAllAndDecodeStartingFrom(
+      BeamFnStateClient beamFnStateClient,
+      StateRequest stateRequestForFirstChunk,
+      Coder<T> valueCoder) {
+    return new UncachedStateIterable<>(beamFnStateClient, 
stateRequestForFirstChunk, valueCoder);
+  }
+
+  static class UncachedStateIterable<T> extends 
PrefetchableIterables.Default<T> {

Review Comment:
   Sorry still not sure I'm understanding.  Are you suggesting just inlining 
this class in StateBackedIterable to avoid having it use the interfaces?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to