robertwb commented on code in PR #34746:
URL: https://github.com/apache/beam/pull/34746#discussion_r2078639724
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateFetchingIterators.java:
##########
@@ -91,6 +94,82 @@ public static <T> CachingStateIterable<T>
readAllAndDecodeStartingFrom(
valueCoder);
}
+ public static <T> UncachedStateIterable<T> readAllAndDecodeStartingFrom(
+ BeamFnStateClient beamFnStateClient,
+ StateRequest stateRequestForFirstChunk,
+ Coder<T> valueCoder) {
+ return new UncachedStateIterable<>(beamFnStateClient,
stateRequestForFirstChunk, valueCoder);
+ }
+
+ static class UncachedStateIterable<T> extends
PrefetchableIterables.Default<T> {
Review Comment:
I meant, e.g. we could probably change declaration at
https://github.com/apache/beam/blob/release-2.60.0/sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java#L77
to be just an Iterable, changing the constructor for
StateBackedIterable[Coder] to not take a Cache at all, etc. But it's also not
too much work to keep it as a Prefetchable iterable given the underlying
iterable is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
