scwhittle commented on code in PR #34873:
URL: https://github.com/apache/beam/pull/34873#discussion_r2084085775
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/coders/AvroCoder.java:
##########
@@ -354,8 +392,10 @@ public Schema get() {
// an inner coder.
private final EmptyOnDeserializationThreadLocal<BinaryDecoder> decoder;
private final EmptyOnDeserializationThreadLocal<BinaryEncoder> encoder;
- private final EmptyOnDeserializationThreadLocal<DatumWriter<T>> writer;
Review Comment:
Yes, this is for compatability across updates in which the pipeline has been
reserialized and may be before and after this change.
There is an updateCompatabilityVersion option that can be used to guard
uncompatible changes but seems simpler in this case to just leave the old
unused fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
