tvalentyn commented on code in PR #34893:
URL: https://github.com/apache/beam/pull/34893#discussion_r2085376348
##########
sdks/python/setup.py:
##########
@@ -417,12 +428,11 @@ def get_portability_package_data():
'scikit-learn>=0.20.0',
'setuptools',
'sqlalchemy>=1.3,<3.0',
- 'psycopg2-binary>=2.8.5,<3.0.0,!=2.9.10',
Review Comment:
How about we instead have two constraints here:
```
'psycopg2-binary>=2.8.5,<2.9.10; python_version <= "3.9"',
'psycopg2-binary>=2.8.5,<3.0; python_version >= "3.10"'
```
This way, it will be easier to maintain by dependabot and eventually easier
to spot that this logic can be cleaned up when Python 3.9 is deprecated.
Adding an OS constraint should be possible too via:
```
sys_platform != "darwin"
sys_platform == "darwin"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
