tvalentyn commented on code in PR #34893:
URL: https://github.com/apache/beam/pull/34893#discussion_r2087452557
##########
sdks/python/setup.py:
##########
@@ -546,20 +556,14 @@ def get_portability_package_data():
# in https://github.com/apache/beam/blob/master/sdks/python/tox.ini
# For more info, see
#
https://docs.google.com/document/d/1c84Gc-cZRCfrU8f7kWGsNR2o8oSRjCM-dGHO9KvPWPw/edit?usp=sharing
- 'torch': [
- 'torch<=1.13.0,<=2.0.0'
- ],
- 'tensorflow': [
- 'tensorflow>=2.12rc1,<2.13'
- ],
+ 'torch': ['torch<=1.13.0,<=2.0.0'],
Review Comment:
i know, my ask was to fix it while at it, since it's a bad practice to have
them:
https://cwiki.apache.org/confluence/display/BEAM/Dependency+management+guidelines+for+Beam+Python+SDK+maintainers#DependencymanagementguidelinesforBeamPythonSDKmaintainers-Howtoaddanewdependency?
My bad, I wasn't clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
