ahmedabu98 commented on code in PR #35043:
URL: https://github.com/apache/beam/pull/35043#discussion_r2114385350
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/providers/GenerateSequenceSchemaTransformProvider.java:
##########
@@ -130,6 +130,18 @@ public static Builder builder() {
@Nullable
public abstract Rate getRate();
Review Comment:
This Rate object already has the fields necessary (`elements` and `seconds`)
to control elements per period. Can you check if this works?
If it doesn't work, I think we can just remove Rate and introduce them as
top-level fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
