liferoad commented on code in PR #35043:
URL: https://github.com/apache/beam/pull/35043#discussion_r2117176237


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/providers/GenerateSequenceSchemaTransformProvider.java:
##########
@@ -130,6 +130,18 @@ public static Builder builder() {
     @Nullable
     public abstract Rate getRate();

Review Comment:
   The original idea is to create the similar syntax to 
https://github.com/apache/beam/blob/f9dca88eb62829039e13ba651368b0798e00b5d9/sdks/java/core/src/main/java/org/apache/beam/sdk/io/GenerateSequence.java#L116
 for https://github.com/apache/beam/issues/35034. If you think we should just 
keep `rate`, I am also fine with that. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to