tvalentyn commented on code in PR #35515:
URL: https://github.com/apache/beam/pull/35515#discussion_r2193016238


##########
sdks/python/apache_beam/yaml/yaml_io.py:
##########
@@ -494,6 +494,9 @@ def attributes_extractor(row):
 
 def read_from_iceberg(
     table: str,
+    filter: Optional[str] = None,

Review Comment:
   Could you please add docstrings for new parameters where applicable? LGTM 
for python changes otherwise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to