ahmedabu98 commented on code in PR #35515:
URL: https://github.com/apache/beam/pull/35515#discussion_r2211369175
##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/catalog/IcebergCatalogBaseIT.java:
##########
@@ -460,20 +460,24 @@ public void testReadWithColumnPruning_keep() throws
Exception {
public void testReadWithFilterAndColumnPruning_keep() throws Exception {
Table table = catalog.createTable(TableIdentifier.parse(tableId()),
ICEBERG_SCHEMA);
- List<String> keepFields = Arrays.asList("bool_field", "modulo_5", "str");
+ List<String> keepFields = Arrays.asList("datetime_tz", "modulo_5", "str");
RowFilter rowFilter = new RowFilter(BEAM_SCHEMA).keep(keepFields);
List<Row> expectedRows =
populateTable(table).stream()
.filter(
row ->
- row.getBoolean("bool_field")
+ row.getLogicalTypeValue("datetime", LocalDateTime.class)
+
.isAfter(LocalDateTime.parse("2025-01-01T09:00:00"))
&& (row.getInt32("int_field") < 500 ||
row.getInt32("modulo_5") == 3))
.map(rowFilter::filter)
.collect(Collectors.toList());
+ System.out.println("expected: " + expectedRows);
Review Comment:
nice catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
