shunping commented on PR #35373:
URL: https://github.com/apache/beam/pull/35373#issuecomment-3071605810
However, when looking closely to the comment above the code:
```
# The log level is:
# - WARNING when we are continuing to retry, and have a deadline.
# - ERROR when we will no longer retry, or MAY retry forever.
```
It seems there is something we can improve here. I would recommend we do the
following changes.
<table class="tg"><thead>
<tr>
<th class="tg-0lax">retry_backoff</th>
<th class="tg-0lax">retry_strategy + message</th>
<th class="tg-0lax">should_retry</th>
<th class="tg-0lax">log level</th>
</tr></thead>
<tbody>
<tr>
<td class="tg-0lax" rowspan="4">not None</td>
<td class="tg-0lax">RETRY_ALWAYS + any </td>
<td class="tg-0lax">true</td>
<td class="tg-0lax">WARN</td>
</tr>
<tr>
<td class="tg-0lax"><span
style="font-weight:400;font-style:normal">RETRY_ON_TRANSIENT_ERROR +
</span><br><span style="font-weight:400;font-style:normal">transient
error</span></td>
<td class="tg-0lax">true</td>
<td class="tg-0lax">WARN</td>
</tr>
<tr>
<td class="tg-0lax"><span
style="font-weight:400;font-style:normal">RETRY_ON_TRANSIENT_ERROR +
</span><br><span style="font-weight:400;font-style:normal">non-transient
error</span></td>
<td class="tg-0lax">false</td>
<td class="tg-0lax"><s>WARN</s> ERROR</td>
</tr>
<tr>
<td class="tg-0lax">RETRY_NEVER + any</td>
<td class="tg-0lax">false</td>
<td class="tg-0lax"><s>WARN</s> ERROR</td>
</tr>
<tr>
<td class="tg-0lax" rowspan="4">None</td>
<td class="tg-0lax">RETRY_ALWAYS + any</td>
<td class="tg-0lax">false</td>
<td class="tg-0lax">ERROR</td>
</tr>
<tr>
<td class="tg-0lax"><span
style="font-weight:400;font-style:normal">RETRY_ON_TRANSIENT_ERROR +
</span><br><span style="font-weight:400;font-style:normal">transient
error</span></td>
<td class="tg-0lax">false</td>
<td class="tg-0lax"><s>WARN</s> ERROR</td>
</tr>
<tr>
<td class="tg-0lax"><span
style="font-weight:400;font-style:normal">RETRY_ON_TRANSIENT_ERROR +
</span><br><span style="font-weight:400;font-style:normal">non-transient
error</span></td>
<td class="tg-0lax">false</td>
<td class="tg-0lax"><s>WARN</s> ERROR</td>
</tr>
<tr>
<td class="tg-0lax">RETRY_NEVER + any</td>
<td class="tg-0lax">false</td>
<td class="tg-0lax"><s>WARN</s> ERROR</td>
</tr>
</tbody></table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
