TanuSharma2511 commented on PR #35373: URL: https://github.com/apache/beam/pull/35373#issuecomment-3071995765
In my opinion, for retry_strategy=RETRY_NEVER, there will be only one condition i.e. RETRY_NEVER + any with should_retry= false, so there is no harm in logging ERROR here. This means whatever error we are not retrying, it is worth highlighting that message as ERROR once. @claudevdm can give the final lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org