damccorm commented on code in PR #35569:
URL: https://github.com/apache/beam/pull/35569#discussion_r2208365995
##########
sdks/python/apache_beam/transforms/periodicsequence_test.py:
##########
@@ -350,10 +351,20 @@ def process(self, elem):
start_timestamp=Timestamp.of(1),
stop_timestamp=Timestamp.of(5),
fire_interval=1,
- rebase_timestamp=True)
+ rebase=RebaseMode.REBASE_ALL)
| beam.ParDo(CheckTimeStamp()))
assert_that(ret, is_empty())
+ def test_rebase_timestamp_with_wrong_setting(self):
+ with self.assertRaises(Exception):
+ with TestPipeline() as p:
+ _ = (
+ p | PeriodicImpulse(
+ start_timestamp=Timestamp.of(1),
+ stop_timestamp=Timestamp.of(5),
+ fire_interval=1,
+ rebase=RebaseMode.REBASE_START))
Review Comment:
Why does this throw? Is the assumption that there will be a large enough gap
between start and the pipeline kicking off? If so, lets make the gap as narrow
as possible since this could be runner dependent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
