damccorm commented on code in PR #35569:
URL: https://github.com/apache/beam/pull/35569#discussion_r2208388779
##########
sdks/python/apache_beam/transforms/periodicsequence_test.py:
##########
@@ -350,10 +351,20 @@ def process(self, elem):
start_timestamp=Timestamp.of(1),
stop_timestamp=Timestamp.of(5),
fire_interval=1,
- rebase_timestamp=True)
+ rebase=RebaseMode.REBASE_ALL)
| beam.ParDo(CheckTimeStamp()))
assert_that(ret, is_empty())
+ def test_rebase_timestamp_with_wrong_setting(self):
+ with self.assertRaises(Exception):
+ with TestPipeline() as p:
+ _ = (
+ p | PeriodicImpulse(
+ start_timestamp=Timestamp.of(1),
+ stop_timestamp=Timestamp.of(5),
+ fire_interval=1,
+ rebase=RebaseMode.REBASE_START))
Review Comment:
Oh I see - yeah that is fine. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
