gemini-code-assist[bot] commented on code in PR #35743:
URL: https://github.com/apache/beam/pull/35743#discussion_r2243384371
##########
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java:
##########
@@ -349,6 +350,32 @@ public void testNestedArrayOfBytes() {
pipeline.run();
}
+ @Test
+ public void testNestedDatetime() {
+ List<Instant> dateTimes =
+ ImmutableList.of(Instant.EPOCH, Instant.ofEpochSecond(10000),
Instant.now());
Review Comment:
Using `Instant.now()` in test data can lead to non-deterministic tests if
the test logic changes in the future. It's better to use a fixed instant for
reproducibility, even if this value is not directly used in the assertion.
```suggestion
ImmutableList.of(Instant.EPOCH, Instant.ofEpochSecond(10000),
Instant.ofEpochSecond(20000));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
