vampire-hunter-lincoln commented on code in PR #35743:
URL: https://github.com/apache/beam/pull/35743#discussion_r2244307319
##########
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java:
##########
@@ -349,6 +350,32 @@ public void testNestedArrayOfBytes() {
pipeline.run();
}
+ @Test
+ public void testNestedDatetime() {
+ List<Instant> dateTimes =
+ ImmutableList.of(Instant.EPOCH, Instant.ofEpochSecond(10000),
Instant.now());
Review Comment:
`ImmutableList` cannot contain `null` element, right? Can we add one more
test case to verify this change can support a list of Joda Instant with some
null elements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
