kennknowles commented on code in PR #35919:
URL: https://github.com/apache/beam/pull/35919#discussion_r2288588860
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/read/UnboundedSolaceReader.java:
##########
@@ -181,11 +181,18 @@ public void finalizeReadyMessages() {
@Override
public Instant getWatermark() {
- // should be only used by a test receiver
if (getSessionService().getReceiver().isEOF()) {
return BoundedWindow.TIMESTAMP_MAX_VALUE;
}
- return watermarkPolicy.getWatermark();
+ Instant watermark = watermarkPolicy.getWatermark();
+ if (watermark == null) {
Review Comment:
This value is forbidden from being null, so we shouldn't need the check. It
is not marked `@Nullable` in the class `WatermarkPolicy` and null checking is
enabled for that class so the type should be accurate.
Where is the null coming from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
