Suvrat1629 commented on code in PR #35919:
URL: https://github.com/apache/beam/pull/35919#discussion_r2294279216
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/read/UnboundedSolaceReader.java:
##########
@@ -181,11 +181,18 @@ public void finalizeReadyMessages() {
@Override
public Instant getWatermark() {
- // should be only used by a test receiver
if (getSessionService().getReceiver().isEOF()) {
return BoundedWindow.TIMESTAMP_MAX_VALUE;
}
- return watermarkPolicy.getWatermark();
+ Instant watermark = watermarkPolicy.getWatermark();
+ if (watermark == null) {
Review Comment:
Oh thanks for the explanation I had suspected it to be checkerframework but
I just wanted to be sure.
>So this null that violates the type system is probqably coming from one of
the following places:
>>an external library that returns null but is not annotated that it may
return null,
some part of the Beam codebase where null checking is disabled,
Yeah probably, I'll see what I can come up with when I go through the code.
Until then if you expect me to make any improvements to the pr then please tell
me so.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
