damccorm commented on code in PR #35899: URL: https://github.com/apache/beam/pull/35899#discussion_r2288997811
########## sdks/python/apache_beam/typehints/typehints.py: ########## @@ -1522,7 +1525,10 @@ def is_consistent_with(sub, base): # Cannot check unsupported parameterized generic which will cause issubclass # to fail with an exception. return False - return issubclass(sub, base) + try: + return is_subhint(sub, base) + except (BeartypeDoorException): + return False Review Comment: Should we gate this on a pipeline option so that users can disable this for now if they run into issues? Could be part of https://github.com/apache/beam/blob/b67c2aadf59ec84b4421c0ea7a1236e40b444d99/sdks/python/apache_beam/options/pipeline_options.py#L805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org