damccorm commented on code in PR #35899:
URL: https://github.com/apache/beam/pull/35899#discussion_r2291172266
##########
sdks/python/apache_beam/typehints/typehints.py:
##########
@@ -1522,7 +1525,10 @@ def is_consistent_with(sub, base):
# Cannot check unsupported parameterized generic which will cause
issubclass
# to fail with an exception.
return False
- return issubclass(sub, base)
+ try:
+ return is_subhint(sub, base)
+ except (BeartypeDoorException):
+ return False
Review Comment:
Sounds good - I'll leave it up to you whether you'd like it in this PR or a
future one. To be clear, once we have a flag with the ability to turn this off
I have no problem with defaulting to it on (assuming it passes test suites)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
