mohamedawnallah commented on code in PR #35473:
URL: https://github.com/apache/beam/pull/35473#discussion_r2308207561
##########
.github/workflows/beam_PreCommit_Python_Examples.yml:
##########
@@ -53,6 +53,7 @@ env:
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+ ALLOYDB_PASSWORD: ${{ secrets.ALLOYDB_PASSWORD }}
Review Comment:
The CloudSQL instance on Google Cloud expected to fail in the examples since
that workflow change haven't yet switched on. As seeing in the CI logs:
```
____________ EnrichmentTest.test_enrichment_with_google_cloudsql_pg
____________
[gw0] linux -- Python 3.11.12
/runner/_work/beam/beam/sdks/python/test-suites/tox/py311/build/srcs/sdks/python/target/.tox-py311-cloud/py311-cloud/bin/python
self =
<apache_beam.examples.snippets.transforms.elementwise.enrichment_test.EnrichmentTest
testMethod=test_enrichment_with_google_cloudsql_pg>
mock_stdout = <_io.StringIO object at 0x7f388c1adbd0>
def test_enrichment_with_google_cloudsql_pg(self, mock_stdout):
db_adapter = DatabaseTypeAdapter.POSTGRESQL
> with EnrichmentTestHelpers.sql_test_context(True, db_adapter):
apache_beam/examples/snippets/transforms/elementwise/enrichment_test.py:147:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _
/opt/hostedtoolcache/Python/3.11.12/x64/lib/python3.11/contextlib.py:137: in
__enter__
return next(self.gen)
apache_beam/examples/snippets/transforms/elementwise/enrichment_test.py:203:
in sql_test_context
result = EnrichmentTestHelpers.pre_sql_enrichment_test(
apache_beam/examples/snippets/transforms/elementwise/enrichment_test.py:246:
in pre_sql_enrichment_test
os.environ['GOOGLE_CLOUD_SQL_DB_PASSWORD'] = password
<frozen os>:684: in __setitem__
???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _
value = None
> ???
E TypeError: str expected, not NoneType
<frozen os>:758: TypeError
- generated xml file: /runner/_work/beam/beam/sdks/python/test-
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
